You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds basic support for the Multi-Value Proposal. For a tuple type to be considered for multi-value, it must be explicitly marked with readonly first.
So far, this adds basic compiler/binaryen support for outputting multi-value returns, but does not support things like indexing yet
I'm thinking that the next PR should add support type checking for tuples/multi-values, support indexing, and add an SROA pass to identify array literals vs tuples. After that, full support for tuples probably based off of warpo's implementation
The more I think about tuples in AS the more I lean toward the idea that semantically, when we declare [T, U, ...] it should be readonly by default and maybe even implicitly so. Ofc that would be a deviate from TypeScript but we are already stricter than TS in many ways. The reason is that tuples should always be passed by value and never by reference. That is how it is done in all languages, and it greatly simplifies lowering to WebAssembly.
But in our case we still have the hint from the types! It would be more correct to always use readonly [T, U...] but having to write and read that every time and then run into compiler errors saying that tuples must be readonly kw would just be annoying and confusing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JairusSW
changed the title
This PR adds basic support for the Multi-Value Proposal. For a tuple type to be considered for
multi-value, it must be explicitly marked withreadonlyfirst.Related: #1633 #1425
So far, this adds basic compiler/binaryen support for outputting multi-value returns, but does not support things like indexing yet
I'm thinking that the next PR should add support type checking for tuples/multi-values, support indexing, and add an SROA pass to identify array literals vs tuples. After that, full support for tuples probably based off of warpo's implementation